Skip to content

samples: bluetooth: fast_pair: locator_tag: Use SMP UUIDs from header #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

samples: bluetooth: fast_pair: locator_tag: Use SMP UUIDs from header #17457

merged 2 commits into from
Oct 9, 2024

Conversation

@mkapala-nordic
Copy link
Contributor

Replace the custom mcumgr SMP BT UUIDs with the ones available
in the smp_bt.h header file from Zephyr.

Jira: NCSDK-28457

Signed-off-by: Mateusz Kapala [email protected]

@mkapala-nordic mkapala-nordic requested review from a team as code owners September 24, 2024 10:11
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 24, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 24, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@b83478a nrfconnect/sdk-zephyr@d3d3f66 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 24, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: d3d25599595bdb7d8d480170b43f4064d40719e3
zephyr: PR head: d3d3f66845737630687c9018cdb687319b74ec17

more details

sdk-nrf:

PR head: d3d25599595bdb7d8d480170b43f4064d40719e3
merge base: f80548ea263a493c761a6ebb16c06d04b2c6e32f
target head (main): 7f59f243414254a4b2556c60610b8327ee4d8603
Diff

zephyr:

PR head: d3d3f66845737630687c9018cdb687319b74ec17
merge base: b83478a230e79d24d69592274f2a93c9c83958a9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (32) 
samples
│  ├── bluetooth
│  │  ├── fast_pair
│  │  │  ├── locator_tag
│  │  │  │  ├── src
│  │  │  │  │  │ dfu.c
west.yml
zephyr
│  ├── boards
│  │  ├── native
│  │  │  ├── nrf_bsim
│  │  │  │  │ nrf54l15bsim_nrf54l15_cpuapp.dts
│  ├── drivers
│  │  ├── clock_control
│  │  │  ├── clock_control_nrf2_common.c
│  │  │  ├── clock_control_nrf2_common.h
│  │  │  ├── clock_control_nrf2_fll16m.c
│  │  │  │ clock_control_nrf2_hfxo.c
│  ├── dts
│  │  ├── bindings
│  │  │  ├── net
│  │  │  │  ├── wireless
│  │  │  │  │  │ nordic,nrf-radio.yaml
│  │  ├── common
│  │  │  ├── nordic
│  │  │  │  ├── nrf54h20.dtsi
│  │  │  │  │ nrf54l15.dtsi
│  ├── include
│  │  ├── zephyr
│  │  │  ├── bluetooth
│  │  │  │  ├── conn.h
│  │  │  │  ├── cs.h
│  │  │  │  │ hci_types.h
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── transport
│  │  │  │  │  │  │ smp_bt.h
│  ├── soc
│  │  ├── nordic
│  │  │  ├── common
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig.peripherals
│  │  │  │  ├── soc_lrcconf.c
│  │  │  │  │ soc_lrcconf.h
│  │  │  ├── nrf54h
│  │  │  │  ├── power.c
│  │  │  │  ├── soc.c
│  │  │  │  │ soc.h
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── Kconfig
│  │  │  ├── common
│  │  │  │  │ Kconfig
│  │  │  ├── host
│  │  │  │  ├── conn.c
│  │  │  │  ├── conn_internal.h
│  │  │  │  ├── cs.c
│  │  │  │  ├── hci_core.c
│  │  │  │  │ hci_core.h
│  │  │  ├── shell
│  │  │  │  ├── bt.c
│  │  │  │  │ cs.c
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── transport
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ smp_bt.c
│  ├── tests
│  │  ├── bluetooth
│  │  │  ├── shell
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 4
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@mkapala-nordic mkapala-nordic force-pushed the mcumgr-smp-uuids-cp-lt-alignment branch from 0151040 to be31495 Compare October 8, 2024 10:56
@mkapala-nordic
Copy link
Contributor Author

Rebase only

@mkapala-nordic mkapala-nordic force-pushed the mcumgr-smp-uuids-cp-lt-alignment branch from be31495 to 6c6c8c7 Compare October 9, 2024 09:01
@rlubos rlubos mentioned this pull request Oct 9, 2024
Closed
@mkapala-nordic
manifest: Update sdk-zephyr revision
5dfd21a 
Update sdk-zephyr revision to pull mcumgr SMP BT UUIDs defines.

Jira: NCSDK-28457

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic
samples: bluetooth: fast_pair: locator_tag: Use SMP UUIDs from header
d3d2559 
Replace the custom mcumgr SMP BT UUIDs with the ones available
in the smp_bt.h header file from Zephyr.

Jira: NCSDK-28457

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic mkapala-nordic force-pushed the mcumgr-smp-uuids-cp-lt-alignment branch from 6c6c8c7 to d3d2559 Compare October 9, 2024 12:24
@NordicBuilder NordicBuilder removed the DNM label Oct 9, 2024
@mkapala-nordic mkapala-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 9, 2024
@rlubos rlubos merged commit 4229268 into nrfconnect:main Oct 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kapi-no kapi-no kapi-no approved these changes

@MarekPieta MarekPieta MarekPieta approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees

No one assigned

Labels

10-min-review manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mkapala-nordic @NordicBuilder @kapi-no @MarekPieta @nordicjm @rlubos